Hey guys,
I have updated to Newspaper 8.0. At first I had some problems with no margins on any of my pages, but somehow after fiddling with the CSS in my child theme, it magiccaly dissapeared without really changing something.
Now I need help with the following:
The (alt)title of a image appears for a second before actually loading the image which is very ugly. That wasn’t the case before the update. Example: http://www.screencast.com/t/DR1sSnBAq6GK
Also on the homepage the width (of the main page wrapper its called I think) is stretched out to the sides. Please see the problem here > https://tinyurl.com/mgm9h45
Hope to hear from you soon.
Thanks!
Hi,
I have inspected your website but the issue is not present at the moment from what I can see – https://www.screencast.com/t/Jypa1jBqq
For the background issue it could be the child them that is causing this. Try switching to the main theme as a test, clear your cache and check if this has any effect.
Thanks
Hi Simion,
Thank you for your response.
I checked the first issue and it’s only happends on Firefox. Chrome seems to work fine.
The background issue is fixed by activating the parent theme. I only have a functions.php, page.php and header.php besides the style.css in my child theme. I figured out it’s the page.php that is causing the problem.
I don’t just want to throw it out, because it’s in there for a reason, but it has been a while since I’ve edited it. I have no clue what I changed, can you recognize anything?
<?php
/* ----------------------------------------------------------------------------
the default page template
*/
get_header();
//set the template id, used to get the template specific settings
$template_id = 'page';
$loop_sidebar_position = td_util::get_option('tds_' . $template_id . '_sidebar_pos'); //sidebar right is default (empty)
//get theme panel variable for page comments side wide
$td_enable_or_disable_page_comments = td_util::get_option('tds_disable_comments_pages');
//read the custom single post settings - this setting overids all of them
$td_page = get_post_meta($post->ID, 'td_page', true);
if (!empty($td_page['td_sidebar_position'])) {
$loop_sidebar_position = $td_page['td_sidebar_position'];
}
// sidebar position used to align the breadcrumb on sidebar left + sidebar first on mobile issue
$td_sidebar_position = '';
if($loop_sidebar_position == 'sidebar_left') {
$td_sidebar_position = 'td-sidebar-left';
}
/**
* detect the page builder
*/
$td_use_page_builder = td_util::is_pagebuilder_content($post);
if ($td_use_page_builder) {
// the page is rendered using the page builder template (no sidebars)
if (have_posts()) { ?>
<?php while ( have_posts() ) : the_post(); ?>
<div class="td-main-content-wrap td-main-page-wrap">
<div class="td-container">
<?php the_content(); ?>
</div>
<?php
if($td_enable_or_disable_page_comments == 'show_comments') {
?>
<div class="td-container">
<div class="td-pb-row">
<div class="td-pb-span12">
<?php comments_template('', true); ?>
</div>
</div>
</div>
<?php
}
?>
</div> <!-- /.td-main-content-wrap -->
<?php endwhile; ?>
<?php }
} else {
//no page builder detected, we load a default page template with sidebar / no sidebar
?>
<div class="td-main-content-wrap">
<div class="td-container <?php echo $td_sidebar_position; ?>">
<div class="td-crumb-container">
<?php echo td_page_generator::get_page_breadcrumbs(get_the_title()); ?>
</div>
<div class="td-pb-row">
<?php
switch ($loop_sidebar_position) {
default:
?>
<div class="td-pb-span8 td-main-content" role="main">
<div class="td-ss-main-content">
<?php
if (have_posts()) {
while ( have_posts() ) : the_post();
?>
<div class="td-page-header">
<h1 class="entry-title td-page-title">
<span><?php the_title() ?></span>
</h1>
</div>
<div class="td-page-content">
<?php
the_content();
endwhile;//end loop
}
?>
</div>
<?php
if($td_enable_or_disable_page_comments == 'show_comments') {
comments_template('', true);
}?>
</div>
</div>
<div class="td-pb-span4 td-main-sidebar" role="complementary">
<div class="td-ss-main-sidebar">
<?php get_sidebar(); ?>
</div>
</div>
<?php
break;
case 'sidebar_left':
?>
<div class="td-pb-span8 td-main-content <?php echo $td_sidebar_position; ?>-content" role="main">
<div class="td-ss-main-content">
<?php
if (have_posts()) {
while ( have_posts() ) : the_post();
?>
<div class="td-page-header">
<h1 class="entry-title td-page-title">
<span><?php the_title() ?></span>
</h1>
</div>
<div class="td-page-content">
<?php
the_content();
endwhile; //end loop
}
?>
</div>
<?php
if($td_enable_or_disable_page_comments == 'show_comments') {
comments_template('', true);
}?>
</div>
</div>
<div class="td-pb-span4 td-main-sidebar" role="complementary">
<div class="td-ss-main-sidebar">
<?php get_sidebar(); ?>
</div>
</div>
<?php
break;
case 'no_sidebar':
?>
<div class="td-pb-span12 td-main-content" role="main">
<?php
if (have_posts()) {
while ( have_posts() ) : the_post();
?>
<div class="td-page-header">
<h1 class="entry-title td-page-title">
<span><?php the_title() ?></span>
</h1>
</div>
<div class="td-page-content">
<?php
the_content();
endwhile; //end loop
}
?>
</div>
<?php
if($td_enable_or_disable_page_comments == 'show_comments') {
comments_template('', true);
}?>
</div>
<?php
break;
}
?>
</div> <!-- /.td-pb-row -->
</div> <!-- /.td-container -->
</div> <!-- /.td-main-content-wrap -->
<?php
}
get_footer();
Hi,
I have checked the website on Firefox and for me it is not happening. The site is loading very fast with no issue what so ever.
You seem to have fixed the background issue, maybe it was just a missing class from the page container or wrap. It is best before updating the theme to test existing child themes with the new update. Some elements from the theme may not be the same after the update.
Thanks
