HTTPS bug

Posted in: Newsmag
Post count: 36
pixeldynamo
#47248
May 1, 2015 at 1:31 pm

So we’ve recently swung over to using SSL by default on our site, and discovered a bug which prevents video posts from functioning.

While the theme does include a global variable which relies on is_ssl, there are several places where http is hard-coded. The video post header is one of those locations, which means that any site running HTTPS will present an empty iframe.

It was a simple enough fix, but I figured it was worth raising so that it can be fixed in a future release. Remember that is_ssl isn’t reliable on certain hosts, so it’s almost certainly worth including a theme panel option to force SSL in those cases.

Post count: 1291
Emil G
#47420
May 4, 2015 at 1:15 pm

Hi,

We’ll investigate, thanks for your feedback.
PS – could you please point at the location on which you changed the code?

Have a nice day!

  • This reply was modified 11 years by Emil G.
Post count: 36
pixeldynamo
#47691
May 5, 2015 at 7:40 pm

the culprit is renderVideo in td_video_support.php

You hard-coded http:// into the URLs, which won’t work on an HTTPS site.

Post count: 6600
Lucian
#47772
May 6, 2015 at 11:54 am

Hi,

Thanks!
I now noticed that you use theme version 1.7 and this was actually fixed within version 1.7.1 of the theme. You can check the update log on themeforest newsmag product page: http://screencast.com/t/0M2jZWRPGrtg – http://themeforest.net/item/newsmag-news-magazine-newspaper/9512331?WT.oss_phrase=&WT.oss_rank=71&WT.z_author=tagDiv&WT.ac=search_list

We’ll consider your suggestions for future updates, for now you can update the theme: https://forum.tagdiv.com/how-to-update-theme/

Thanks for your message!

Viewing 4 posts - 1 through 4 (of 4 total)
The forum ‘Newsmag’ is closed to new topics and replies.