Hi, Radu/Marius
updated to latest theme version today 1.12.14, and ran into one issue trying to use the async adsense units (created new, proper ad ID, proper user ID).
However when published the code is duplicating the first couple of characters of my publisher ID, causing pull of ads to fail:
e.g.,
<script async src="//pagead2.googlesyndication.com/pagead/js/adsbygoogle.js"></script>
<ins class="adsbygoogle header" style="display:inline-block" data-ad-client="ca-ca-pub-XXXXXXXXXXXXXXXX" data-ad-slot="XXX6870028"></ins>
<script>(adsbygoogle=window.adsbygoogle||[]).push({});</script>where publisher ID is: ca-pub-XXXXXXXXXXXXXXXX
printing to page as: ca-ca-pub-XXXXXXXXXXXXXXXX
ref: http://ga-ga.com/1228/likely-happened-royalties-sugar-man/
FYI: I turned the ad spots off so as to not end up with negative issues with Google’s systems for the moment. Code will not appear in the live pages at this time.
Can’t figure out why I’m getting an extra “ca-” on page seemingly from nowhere.
OKAY! My bad (big giant D’OH!!!)
Not a bug.
If I followed the actual documentation (“RTFM”), it shows to grab only the publisher ID without the “ca-” …
so using just pub-XXXXXXXXXXXXXXXX
vs ca-pub-XXXXXXXXXXXXXXXX
.. worked first time out.
However, on the page the ad is flush top to logo area vs vertically aligned.
As here: http://ga-ga.com/1228/likely-happened-royalties-sugar-man/
Hello Christopher,
thanks for the feedback.. I was thinking to remove the ca- automatically… I too had problems with it :).
Regarding the ad position, today I’m releasing an update to fix that. Sorry about it.
Hi, Radu!
I’m just glad you figured out a way to do the async ads (remember my post way back in the “coding” category). That is one tricky beast!
By the way … one way to make a quick and easy “web safe fonts” methodology for folks would be to change the default fonts in your main style.css to something like this:
font-family: Segoe, "Segoe UI", "DejaVu Sans", "Trebuchet MS", Verdana, sans-serif
font-family: Constantia, "Lucida Bright", "DejaVu Serif", Georgia, serif
and then by default folks could simply leave fonts as “default” in the theme customizer; -or- switch on the Google fonts if they needed them.
This would be a super simple way for you to answer everybody’s thing about fallback to web-safe fonts without having to recode.
Just use the above in your style vs the Google fonts, and then let people turn “on” the Google fonts to match your demo.
OR: you could provide an alt-stlye.css using above replacement, and then tell folks in docs to rename to style.css to use web safe fonts.
Just an idea 🙂 (I was playing around with that).
Of course, this doesn’t solve the load of the fonts in the functions.php file by default, but a savvy person could strip that out if they knew they only wanted to use web fonts.
I could post a how-to on this ‘hack’ but I’m going to presume at some point it would be better to have the Google fonts be optional “all off” and “don’t load in header the pulls to Google CDN” vs doing hacks.
Thinking out loud. 🙂
interesting new WORDPRESS PLUGIN BY GOOGLE (!)
Hello Christopher,
for the fonts: We are moving the site to a new panel / settings sistem and after we are done with that we will implement a much better fonts system – including support for web safe fonts. I have some solutions in mind so that’s not the problem… the problem is we did not manage to do them yet due to time constraints 🙂 .
for the google plugin… I don’t know what to say. It doesn’t offers to much functionality and the spots that it suggests for ads are not that ok. In v3 we have a simple one code / ad spot system. The responsive and re sizing of the ad is done by the theme automatically … even for adsense.
HI, Radu
thanks for update. I knew you were working on the fonts thing for next “edition.”
For the Google plugin, I don’t think we would end up using it but it was announced the other day. I think your solution is awesome (once the top bar alignment thing is sorted).
Keep up the great work!
CS
