Incorrect Feedburner ID handling in the Newsletter plugin

Posted in: Newsmag
Post count: 3
Maxime
#230392
Apr 25, 2018 at 6:08 am

I have tried to setup the Newsletter plugin coming with the Newsmag theme.
Unfortunately it was not accepting ID of my Feedburner feed, which I have been using for years.

It turned out that Feedburner ID validity check in the plugin is incorrect. Apart from alphanumeric characters the following characters are valid for Feedburner ID: ‘-‘, ‘_’, ‘.’, ‘~’. SO the following patch has solved the issue:

--- tds_newsletter1.php.orig 2018-04-25 12:00:34.656316253 +1000
+++ tds_newsletter1.php 2018-04-25 12:00:38.768254940 +1000
@@ -380,7 +380,7 @@

$newsletter_data = array();

- if( ctype_alnum ($newsletter_form_data) ) {
+ if( ctype_alnum (str_replace(array('-', '_', '.', '~'), '', $newsletter_form_data)) ) {
// valid username, alphanumeric
$newsletter_data['id'] = $newsletter_form_data;

Post count: 23312
Catalin
#230406
Apr 25, 2018 at 9:20 am

Hello Maxime,

Thanks for your suggestion. Maybe this will be useful for our customers.

Viewing 2 posts - 1 through 2 (of 2 total)
You must be logged in to reply to this topic.