Hey guys and girls – great job with the new Version three ! Love it..!
I’ve just spun it up in a dev environment and have noticed the following extra css elements being hard coded in the overarching theme style.css:
Line 24237: .mfp-content .td-login-wrap .btn { background-color: #4db2ec }
Line 24290: .mfp-content .td_login_tab_focus { background-color: #4db2ec }
Line 24310: .mfp-content .td-login-panel-title { background-color: #4db2ec }
Line 24318: .mfp-content .td_display_err { background-color: #4db2ec }
Unless I am mistaken, won’t these elements overwrite any custom themed colours defined in the theme panel for the login menu on a greater than 767 pixel display ? No big deal, I suppose, but it will most likely reset colour schemes for some people (and only in the logon modal on a bigger screen).
For now, I have simply remmed them out in my code, but this seems very clunky and obviously will reset when the next GA comes out.
… Or am I doing something the wrong way (entirely possible)?
Oh and:
Line 24289: .mfp-content .td_login_tab_focus { background-color: #4db2ec }
Line 24329: .mfp-content .td_display_msg_ok { background-color: #4db2ec }
Hi
The css from theme panel it’s loaded after main css from style.css. The code from theme panel will overwrite the style from style.css so there shouldn’t be any issue with that.
Thanks!
Do you mean the color picker panel from the theme panel? because that didnt seem to take any effect.. 🙁
As soon as i remmed out these entries, my login panel picked up the colours that were set in the colors chosen in the theme panel (like they were in v2)?
Or did you mean the custom css “code” section?
I can confirm that there are no specific overrides for the mfp-content class…
I can see the override below, but it doesn’t target the new login modal in fullscreen….
.td-header-border::before, .td-trending-now-title, .td_block_mega_menu .td_mega_menu_sub_cats .cur-sub-cat, .td-post-category:hover, .td-header-style-2 .td-header-sp-logo, .td-next-prev-wrap a:hover i, .page-nav .current, .widget_calendar tfoot a:hover, .td-footer-container .widget_search .wpb_button:hover, .td-scroll-up-visible, .dropcap, .td-category a, input[type=”submit”]:hover, .td-post-small-box a:hover, .td-404-sub-sub-title a:hover, .td-rating-bar-wrap div, .td_top_authors .td-active .td-author-post-count, .td_top_authors .td-active .td-author-comments-count, .td_smart_list_3 .td-sml3-top-controls i:hover, .td_smart_list_3 .td-sml3-bottom-controls i:hover, .td_wrapper_video_playlist .td_video_controls_playlist_wrapper, .td-read-more a:hover, .td-login-wrap .btn, .td_display_err, .td-header-style-6 .td-top-menu-full, #bbpress-forums button:hover, #bbpress-forums .bbp-pagination .current, .bbp_widget_login .button:hover, .header-search-wrap .td-drop-down-search .btn:hover, .td-post-text-content .more-link-wrap:hover a, #buddypress div.item-list-tabs ul li > a span, #buddypress div.item-list-tabs ul li > a:hover span, #buddypress input[type=”submit”]:hover, #buddypress a.button:hover span, #buddypress div.item-list-tabs ul li.selected a span, #buddypress div.item-list-tabs ul li.current a span, #buddypress input[type=”submit”]:focus, .td-grid-style-3 .td-big-grid-post .td-module-thumb a:last-child::before, .td-grid-style-4 .td-big-grid-post .td-module-thumb a:last-child::before, .td-grid-style-5 .td-big-grid-post .td-module-thumb::after, .td_category_template_2 .td-category-siblings .td-category a:hover, .td-weather-week::before, .td-weather-information::before
Steps to replicate issue on a fresh install:
Set up a vanilla site. Change the colour scheme from blue backgrounds and blue writing to say red or something.
You will see nothing will update the colours of the login modal in full screen mode. Only applying forced custom css will work.
If this is by design, great – but in version 2 some colours did apply.
Hi
The color for the login modal won’t change because the selectors are not included on the list. The theme does not have an option which change these colors so only custom css can do it by targeting the specific selectors.
Thanks!
Hmm.. OK.. I changed my colour scheme in Version 2 of this theme, and they disappeared on the login modal box only when I updated to Version 3… Was it accidental that my login modal box was taking on colours from the theme’s color panel in version 2?
I realise a few extra parts were added / split off with the new mobile menu that has been created, but I guess I just assumed whoever recoded the login box simply used a new range of style tags that had not been included in the color lists… but if you say it was never meant to be like that, fair enough.
It seems weird to me that the overide CSS that gets applied on the same page as the login window includes “.td-login-wrap” as an overide (it never applies, because it’s not specific enough) – even in your version 3 color code overrides…..
..”.td-login-wrap” was the old class that was used in V2’s old login box used to use before you introduced .mfp-content in front of that selector….. Are you sure? If so, that’s a waste of a css tag if it’s not meant to do anything..
Either way, there’s a “problem here:
if td-login-wrap is not supposed to affect colours, it should be taken out (since it’s not doing anything)
or
if the colours are meant to be adjusted, the css overrides for td-login-wrap should be updated to include the new prefix: eg; “mfp-content .td-login-wrap {”
(Specific Example: This is an override the appears in the css relevant to the login modal box – it includes an override for “.td-login-wrap” {V2 style login}, but not “.mfp-content .td-login-wrap” {V3 style login} – the login css should be either removed or updated from this override 🙂 :
.td-header-border::before, .td-trending-now-title, .td_block_mega_menu .td_mega_menu_sub_cats .cur-sub-cat, .td-post-category:hover, .td-header-style-2 .td-header-sp-logo, .td-next-prev-wrap a:hover i, .page-nav .current, .widget_calendar tfoot a:hover, .td-footer-container .widget_search .wpb_button:hover, .td-scroll-up-visible, .dropcap, .td-category a, input[type=”submit”]:hover, .td-post-small-box a:hover, .td-404-sub-sub-title a:hover, .td-rating-bar-wrap div, .td_top_authors .td-active .td-author-post-count, .td_top_authors .td-active .td-author-comments-count, .td_smart_list_3 .td-sml3-top-controls i:hover, .td_smart_list_3 .td-sml3-bottom-controls i:hover, .td_wrapper_video_playlist .td_video_controls_playlist_wrapper, .td-read-more a:hover, .td-login-wrap .btn, .td_display_err, .td-header-style-6 .td-top-menu-full, #bbpress-forums button:hover, #bbpress-forums .bbp-pagination .current, .bbp_widget_login .button:hover, .header-search-wrap .td-drop-down-search .btn:hover, .td-post-text-content .more-link-wrap:hover a, #buddypress div.item-list-tabs ul li > a span, #buddypress div.item-list-tabs ul li > a:hover span, #buddypress input[type=”submit”]:hover, #buddypress a.button:hover span, #buddypress div.item-list-tabs ul li.selected a span, #buddypress div.item-list-tabs ul li.current a span, #buddypress input[type=”submit”]:focus, .td-grid-style-3 .td-big-grid-post .td-module-thumb a:last-child::before, .td-grid-style-4 .td-big-grid-post .td-module-thumb a:last-child::before, .td-grid-style-5 .td-big-grid-post .td-module-thumb::after, .td_category_template_2 .td-category-siblings .td-category a:hover, .td-weather-week::before, .td-weather-information::before
Change these lines of code in ~/includes/td_css_generator.php and re-save your colours in the theme panel, and it’s back to V2 behavior:
Line 35: .mfp-content .td-login-wrap .btn,
Line 36: .mfp-content .td_display_err,
Line 158: .mfp-content .td_login_tab_focus {
Line 167: .mfp-content .td-login-panel-title,
..I say its a “bug” – a very minor one.
Hi
Thanks for reporting this. I’ve added this on our list and we will look into it as soon as possible.
