Search Results for 'github'

Hi,

We haven’t taken the time to add an answer this topic for a while but we still have a problem.

Images still don’t load correctly since we have updated the theme last June. The problem is that we have to choose “media file” when we upload an image so that the lightbox works properly. It could be a solution, if we didn’t have thousands of old posts that don’t work correctly since the update, because uploaded images are not set with the “media file” property, but “Attachment page”. With this option, the image doesn’t show correctly, as you can see on this example : https://nofrag.com/2019/06/18/138137/

The image is visible, as you’ve written in your first reply, but if you click on the image, you’ll see the lightbox embed with your theme failing to show the image in fullscreen, displaying a message “The image could not be loaded”. As a workaround, we use another lightbox plugin (simple lightbox), which shows correctly the image (in “media file” or “attachment page” mode) but as I’ve written, it’s just a workaround: your lightbox is still called by the user click and he will see the error message before the image.

I’ve seen that click on an image calls a JS script which use “magnific popup” script (https://github.com/dimsemenov/Magnific-Popup) in your td composer plugin, and I’ve found no option to disable this script. We have already installed the last release of this plugin but it doesn’t fix our problem.

We would like to use your lightbox instead of using a third party plugin, or completely disable your lightbox if you’re not planning to fix it. Could you help us ?

With your permission I will add a small comment.

SVG (Scalable Vector Graphics) is an XML-based vector image format, so it’s better to create your logo in a vector editor (I recommend Adobe Illustrator for example). After re-saving your logo to SVG format, optimize it via this service: https://jakearchibald.github.io/svgomg/ which guarantees the correct rendering in all modern browsers.

Hi Calin,

I was very busy with migrating that 140k pages site, so I didn’t take the time to look into this until now.

So I just prettified the script_for_front.js and had a quick look and the fix seams real easy.

somewhere around line 350 I see this


a.jqueryObj.find(".tdb-head-search-form-input").keydown(function (b)
{
if (b.which && 39 === b.which || b.keyCode && 39 === b.keyCode || b.which && 37 === b.which || b.keyCode && 37 === b.keyCode) tdbSearch.set_input_focus(a);
else
{
if (b.which && 13 === b.which || b.keyCode && 13 === b.keyCode) return b =
a.jqueryObj.find(".tdb-aj-cur-element"), 0 < b.length ? window.location = b.find(".entry-title a").attr("href") : jQuery(this).parent().parent().submit(), !1;
if (b.which && 40 === b.which || b.keyCode && 40 === b.keyCode) return tdbSearch.move_prompt_down(a), !1;
if (b.which && 38 === b.which || b.keyCode && 38 === b.keyCode) return tdbSearch.move_prompt_up(a), !1;
(b.which && 8 === b.which || b.keyCode && 8 === b.keyCode) && 1 === jQuery(this).val().length && a.jqueryObj.find(".tdb-aj-search").empty();
tdbSearch.set_input_focus(a);
setTimeout(function ()
{
tdbSearch.do_ajax_call(a)
},
100);
return !0
}
});


looking just on the last few lines

replacing this

setTimeout(function ()
{
tdbSearch.do_ajax_call(a)
},
100);


by that

debounce(
setTimeout(function () {
tdbSearch.do_ajax_call(a)
}, 0),
250
);


first you would need this https://davidwalsh.name/javascript-debounce-function
actually coming from an old version of underscore (it works!)

function debounce(func, wait, immediate) {
var timeout;
return function() {
var context = this, args = arguments;
var later = function() {
timeout = null;
if (!immediate) func.apply(context, args);
};
var callNow = immediate && !timeout;
clearTimeout(timeout);
timeout = setTimeout(later, wait);
if (callNow) func.apply(context, args);
};
};


this is the actual up to date function on https://github.com/jashkenas/underscore/blob/master/underscore.js
but perhaps underscore can be useful to have in such a project

I see here that _.debounce requires _.delay who needs restArguments
this could be the “light” way that does the trick too

// Some functions take a variable number of arguments, or a few expected
// arguments at the beginning and then a variable number of values to operate
// on. This helper accumulates all remaining arguments past the function’s
// argument length (or an explicit startIndex), into an array that becomes
// the last argument. Similar to ES6’s "rest parameter".
var restArguments = function(func, startIndex) {
startIndex = startIndex == null ? func.length - 1 : +startIndex;
return function() {
var length = Math.max(arguments.length - startIndex, 0),
rest = Array(length),
index = 0;
for (; index < length; index++) {
rest[index] = arguments[index + startIndex];
}
switch (startIndex) {
case 0: return func.call(this, rest);
case 1: return func.call(this, arguments[0], rest);
case 2: return func.call(this, arguments[0], arguments[1], rest);
}
var args = Array(startIndex + 1);
for (index = 0; index < startIndex; index++) {
args[index] = arguments[index];
}
args[startIndex] = rest;
return func.apply(this, args);
};
};

Perhaps you all ready have underscore? but didn’t spot it in that js

… it’s got nice goodies and comes handy 🙂 (17.6 KB not so bad ?)

hope this comes helpful, have a nice day.

oups editing code here is dangerous ö

• This reply was modified 6 years by cantoute. Reason: forgot restArguments
• This reply was modified 6 years by cantoute. Reason: forgot restArguments

Appears this issue relates to Chrome version 77.x and not Newsmag itself:

https://github.com/WordPress/gutenberg/issues/11060

Looks like it was an issue with a recent update of the AMP plugin:

https://github.com/ampproject/amp-wp/releases

Fixes: “Prevent empty srcset for images in galleries.”

The link to the code throws a 404:

Here is my own version: https://github.com/renduples/tagDiv-Newspaper-CoAuthors-Plus

Hi, thank you! The banner image takes you to the home page.

Just checked the homepage and the 6 – 10 images aren’t linking as I haven’t set them to link. Setting them to link in the media settings has fixed the issue.

I’m using this: https://github.com/GiacomoLaw/tagdiv-cdn-modal/blob/master/tagdiv-cdn-modal.php as I have a CDN, so I need to use that to fix it as Tagdiv haven’t allowed CDNs to be used with the modal.

Thank you for your reply.

What if I want to use something like slick slider, which has multiple module with touchable to scroll in a row for mobile view?
https://kenwheeler.github.io/slick/

I considered to use normal slider that you are providing us, but I only see one module in a row on the slider.

Speaking of slider, will not be able to set “%” for image hight? I want to set 16:9 aspect ratio, so I tried “56%”. But it doesn’t work.

Sorry for my bad explanation.

• This reply was modified 7 years by Ken0929.

I’m looking to update from version 9.5 to the latest. Can i do that directly or do i need up update the last one first?

I installed the Evato plugin from github and it does not detect that the newspaper theme is installed. It detects that I have purchased the themes but not installed.

• This reply was modified 7 years by Rikk.

Try this :
https://github.com/sLaNGjI/wp-missed-schedule/