Was td_api_header_style::_helper_show_header(); deprecated?

Posted in: Newspaper
Post count: 17

Edit:

Do you list functions/methods/classes that you deprecate?

When I updated to the latest version (9.5) I am now getting

Fatal error: Uncaught Error: Call to undefined method td_api_header_style::_helper_show_header() in /Users/mgargano/Sites/jerusaysyoureplayingyourself.com/site/web/app/themes/Newspaper-child/header.php on line 32
( ! ) Error: Call to undefined method td_api_header_style::_helper_show_header() in /Users/mgargano/Sites/jerusaysyoureplayingyourself.com/site/web/app/themes/Newspaper-child/header.php on line 32

I see a method called show_header() is that a replacement for td_api_header_style::_helper_show_header() ?

Thanks,
P*

  • This topic was modified 7 years by mgargano.
Post count: 35449

Hi,

Please make sure that you follow the update of theme like in our documentation -> https://forum.tagdiv.com/how-to-update-the-theme-2/
Install via FTP – https://forum.tagdiv.com/install-via-ftp/
Install via WordPress – https://forum.tagdiv.com/install-via-wordpress/.

If you have child theme please deactivate it until you update/install the theme.
We recommend to be made via FTP.

If there is still a problem, you can send us an email at contact@tagdiv.com and provide admin login, as well as cPanel or FTP if possible. We will take a look. Include a link to this topic in the email.

Thank you!

Post count: 17

I asked a very specific development related question and your response is generic wordpress information.

Please re-read my question and answer accordingly.

Thanks,
Mat

Post count: 35449

Hi,

Did you follow the steeps from above? that error is from child theme, is not compatible with the new version of newspaper.

I can’t say if that is an replace or not, because I do not know what version of theme did you have before update, but this is caused by the settings from child theme.

If there is still a problem, you can send us an email at contact@tagdiv.com and provide admin login, as well as cPanel or FTP if possible. We will take a look. Include a link to this topic in the email.

Thank you for your understanding!

Post count: 17

It’s a rather simple 2 questions. In the update from 9.2.2 to 9.5.0 was td_api_header_style::_helper_show_header(); deprecated?

Do you keep track of deprecation of functions and methods in your theme?

Post count: 8

Hello Calin
I have the same problem. But does it mean that the Envato plugin that we use for Updates is not Good?
So Every time a new update comes up, we have to download and upload again, what happens to those that have some mini customizations on their site.
They will start over to customize again?
Whats the Envato plugin used for then if I can’t use to update and get everything clean directly from my dashboard.

Please, what is the Simplest way to fix this Error my website is just down because of it.
Thank you.

Post count: 72

I also just updated 9.2.2 to 9.5.0 and have the exact same error:
Uncaught Error: Call to undefined method td_api_header_style::_helper_show_header()

Right, keeping track of deprecations is a *must* 🙂

Post count: 72

I see on https://themeforest.net/item/newspaper/5489609 that there are 2 additions:

new: Introducing the Header Builder. Now you have the power to create completely different headers for various pages, sticky headers on desktop and mobile, but also special headers for small screen devices.
new: The Header Manager. This feature allows you to have a different header on templates (think of it as your Headers Assign System :p)

Perhaps this is related to the errors we see?

Post count: 35449

Hi,

This update comes with the opportunity to build your own header, something that was not possible until now, so if you have in child theme changes make for header is possible that those now longer to work, that is way you’ll need to deactivate the child theme and after that try to install the theme.
What you can do is to change the header in child theme ( the old one with the new one).

Also if you make the theme update via FPT you’ll not lose the settings make in theme panel, will be lose only the changes made in theme files ( this is happen if you are using the envato plugin too ).

Thank you for your understanding!

Post count: 17

You still did not answer my questions:

  1. In the update from 9.2.2 to 9.5.0 was td_api_header_style::_helper_show_header(); deprecated?
  2. Do you keep track of deprecation of functions and methods in your theme?
Post count: 72

Ahhhh, this is frustrating. Not only does this appear to blow out child themes, it also is not following best practices in keeping track of deprecated functions…


@ncalex
the wording on your response is unclear. Do you suggest FTP is better than using Envato plugin?

Post count: 35449

Hi @mgargano,

Maybe you want to say if is still use this function td_api_header_style::_helper_show_header(), if is so then the answer is no, that function is not longer use, that function was made for default header, now the v9.5 include the Header Builder and the header file was change, this is one of the disadvantage using child theme ( custom elements ) you need to follow the theme updates and check if the child is still compatible.
Here is the list with the modified files -> https://tagdiv.com/td_deploy/Newspaper/changed_files_9.2.1_9.5.html
-> https://www.screencast.com/t/VJqI0ip0pOA

This is a major update, you’ll need to make a new child theme after current theme and set in it the changes from the old one.


@paperweight
we recommend to be made via FTP.
Is possible that Envato Market API to have some delays on available updates.

Thank you for your understanding!

Post count: 17

@calin

I mean exactly what I said.

It seems that you are not keeping track of deprecations.

That is a major problem.

If you are not properly deprecating functions and not following semantic versioning I cannot trust this theme for any of my production sites that I manage.

  • This reply was modified 7 years by mgargano.
Post count: 35449

Hi,

Unfortunately we do not have a page reports so thorough with the changes like this one -> https://developers.google.com/admin-sdk/reports/v1/reference/usage-ref-appendix-a/customers-docs ; also this is the first time anyone has mentioned something like this, sorry for the inconvenience!

Thank you for your understanding!

Post count: 72

I love the Newspaper theme, but there are fundamental tenets of coding. One of those tenets is clear changelog:
https://wordpress.org/news/2009/07/improving-your-plugin-changelogs/

Keeping track of deprecated functions is a very very big thing. I’ve been part of the WP community for more than 13 years (I have a very old username on wordpress.org) and I have built and funded dozens of plugins over the years. It’s very very very imprtant for Newspaper, which is a very very popular plugin, to have accurate data given to consumers. Please let me know fi I can assist you — I want to see you guys do great!

Post count: 35449

Hi,

We’ll take this suggestion in consideration and will improve our changelog -> https://www.screencast.com/t/6GzJDm8pKet -> https://themeforest.net/item/newspaper/5489609?s_rank=1
Sorry for the inconvenience!

Thank you for your understanding!

Viewing 16 posts - 1 through 16 (of 16 total)
The forum ‘Newspaper’ is closed to new topics and replies.