I archive every version of the theme (since Feb 2014) carefully. I just unpacked the WP theme zip (full source) and here is what I have in /wp_booster/. Notice files are sorted alphabetically, ASC, and there is no td_options.php file in that archive. I’ve included my directory tree on the left so you can see where things are.
Not to argue or anything, but your statement appears incorrect. There is no /wp_booster/td_options.php file in 7.4, 7.3, 7.2, 7.1.1, 7.1, 7.0.1, or 7. I’ve checked my source downloads.
Found the answer to the real problem, and it was simple.
I added lines 44 and 46 in that file.
While building the array of shortcodes used to determine which template to use, I added a check for the string vc_, which is the beginning of all VC shortcodes (can’t use VC without first having a row, etc.) in the foreach loop, and only if that string is found does it add the item to the array that is later checked against the post content. This way, the automatic changes based on whether VC is used works as intended, and as clearly stated in the theme’s documentation.
Tested with several shortcodes and so far it’s only catching when an actual VC shortcode is used.
That is normal WordPress behavior.
Everything else works as expected.
Problem is, on a fresh WP install with any other theme, the use of ANY shortcode in a page maintains the basic elements of a page template (title, body). Searching for ANY shortcode to decide whether or not VC is being used is a bug. To go by your own documentation:
If VC is used, the page title will not show. I didn’t use VC and the page title didn’t show. You see where I’m going with this?
Whatever conditional is being used to check for a shortcode is not limited to a regex for VC only shortcodes and is tripping on any and every shortcode available. It essentially ruins the shortcode feature of the whole page system in WP. It modifies core behavior in a round about way that doesn’t actually change core code.
I can edit this myself, sure, and I can even keep maintaining it across updates, but that’s just a band aid for the bigger problem. This isn’t a localized issued. Also not a difficult fix… ** correction. It’s not a difficult fix for you because you know the VC methods used and how they cross with NP methods. Looking at the code, it looks like you’re depending on VC’s own internal array of shortcodes and then not filtering through them at all aside from adding the leading bracket to the shortcode names. Literally checking if it’s empty or not and nothing else…
`
if (is_array($td_page_builder_short_codes) && !empty($td_page_builder_short_codes)) {
foreach ($td_page_builder_short_codes as $short_code_name){
// we have to add [ before the shortcode name, else it may target simple words that match with the shortcode name
$short_codes_buffer[] = ‘[‘ . $short_code_name;
}
}
if (!empty($short_codes_buffer) && td_util::strpos_array($post->post_content, $short_codes_buffer) === true) {
$td_use_page_builder = true;
}
`
If it’s not going to be fixed, then the above screenshot shows text that must be changed, because ALL I’m wanting is for the software to do what it says there; if VC is used, no title, if VC is not used, page title. Simple.
Thanks.
Okay, so I’ve left my setup in learning mode 2-3 weeks and found something everyone should know. While in learning mode, you use the theme panel so Wordfence can learn to let the admin-ajax.php calls through, but it’s not that that simple.
Wordfence not only sets exceptions for admin-ajax.php, but for the parameters that are sent to it. Every setting in the theme is a different parameter.
So the way you have to use Wordfence with a tagDiv theme is simply to turn learning mode on during periods when you’re adjusting theme settings. When done, turn learning mode back off so you’re protected. Then, if you change a theme setting that you already used specifically in learning mode, it’ll always work, but if you get to a new one that you didn’t adjust while in learning mode, it will be blocked by Wordfence. That’s why you turn learning mode back on.
I admit, it’s a slight pain to go back and forth, but having this great theme with good security? Can’t beat that.
Hope this helps.
